Skip to content

Now use common lombok configuration #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2023
Merged

Now use common lombok configuration #281

merged 4 commits into from
Jul 12, 2023

Conversation

Tristan-WorkGH
Copy link
Contributor

Use the common lombok configuration introduce in powsybl/powsybl-parent#44

@Tristan-WorkGH Tristan-WorkGH added the enhancement New feature or request label Jul 5, 2023
@Tristan-WorkGH Tristan-WorkGH requested a review from jonenst July 5, 2023 12:48
@Tristan-WorkGH Tristan-WorkGH self-assigned this Jul 5, 2023
@Tristan-WorkGH Tristan-WorkGH marked this pull request as draft July 5, 2023 12:57
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Jul 6, 2023
Open
@Tristan-WorkGH Tristan-WorkGH force-pushed the migrate_lombok_configuration branch from f774032 to 85831cb Compare July 11, 2023 12:51
@Tristan-WorkGH Tristan-WorkGH force-pushed the migrate_lombok_configuration branch 2 times, most recently from 64eabc9 to 74c478d Compare July 12, 2023 09:55
@Tristan-WorkGH Tristan-WorkGH marked this pull request as ready for review July 12, 2023 09:58
@Tristan-WorkGH
Copy link
Contributor Author

@jonenst here the checkpoint

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 1 Code Smell

50.0% 50.0% Coverage 0.0% 0.0% Duplication

@Tristan-WorkGH Tristan-WorkGH force-pushed the migrate_lombok_configuration branch 5 times, most recently from 1d86f6f to 35a9138 Compare July 12, 2023 12:11
@Tristan-WorkGH
Copy link
Contributor Author

SonarCloud Quality Gate failed. Quality Gate failed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 1 Code Smell

3.6% 3.6% Coverage 0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@jonenst here the checkpoint for lombok without the new parent

@Tristan-WorkGH Tristan-WorkGH force-pushed the migrate_lombok_configuration branch 3 times, most recently from 9dfcfcc to ddf6355 Compare July 12, 2023 12:38
@Tristan-WorkGH Tristan-WorkGH force-pushed the migrate_lombok_configuration branch from f0d5555 to bd4b4d3 Compare July 12, 2023 12:52
@Tristan-WorkGH
Copy link
Contributor Author

branch cleaned for PR

@Tristan-WorkGH
forget it
18ed9fe 
Signed-off-by: Tristan Chuine <[email protected]>
@Tristan-WorkGH
not necessary ?
b963ef8 
Signed-off-by: Tristan Chuine <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonenst jonenst merged commit 057e450 into main Jul 12, 2023
@jonenst jonenst deleted the migrate_lombok_configuration branch July 12, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonenst jonenst jonenst approved these changes

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tristan-WorkGH @jonenst