Skip to content

Fix DTO visibility #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix DTO visibility #284

merged 1 commit into from
Jul 13, 2023

Conversation

Tristan-WorkGH
Copy link
Contributor

The DTO should by convention in Java have all there parameters private and accessible with a getter following the name getXXX().
The getter is done by lombok @Getter or @Data.

@Tristan-WorkGH Tristan-WorkGH added the enhancement New feature or request label Jul 6, 2023
@Tristan-WorkGH Tristan-WorkGH requested a review from jonenst July 6, 2023 13:14
@Tristan-WorkGH Tristan-WorkGH self-assigned this Jul 6, 2023
@Tristan-WorkGH Tristan-WorkGH requested a review from flomillot July 10, 2023 14:43
@Tristan-WorkGH Tristan-WorkGH force-pushed the fix_dto_parameters_visibility branch from 10b326d to 0b10c36 Compare July 13, 2023 11:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Tristan-WorkGH Tristan-WorkGH merged commit 89622a2 into main Jul 13, 2023
@Tristan-WorkGH Tristan-WorkGH deleted the fix_dto_parameters_visibility branch July 13, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants