Skip to content

Computation debug mode #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Computation debug mode #737

wants to merge 26 commits into from

Conversation

thangqp
Copy link
Contributor

@thangqp thangqp commented Apr 25, 2025

No description provided.

@thangqp thangqp requested a review from etiennehomer May 16, 2025 14:01
@thangqp thangqp requested a review from Mathieu-Deharbe June 11, 2025 09:18
@@ -130,6 +132,7 @@ public class NotificationService {
public static final String ROOT_NETWORKS_UPDATE_FAILED = "rootNetworksUpdateFailed";

public static final String STUDY_ALERT = "STUDY_ALERT";
public static final String STUDY_DEBUG = "STUDY_DEBUG";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static final String STUDY_DEBUG = "STUDY_DEBUG";
public static final String COMPUTATION_DEBUG_DOWNLOAD = "COMPUTATION_DEBUG_DOWNLOAD";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with the naming of the notification method, I have changed updateType to COMPUTATION_DEBUG_FILE_STATUS = "computationDebugFileStatus"

DONE in d2ab722

Copy link

Signed-off-by: Thang PHAM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants