Skip to content

Conversation

@eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Nov 1, 2025

  • Replace deprecated usage of astroid.Const with astroid.nodes.Const
  • Add manager argument to AstroidBuilder since the default argument was removed on astroid 4.x
  • Adapt the tests to treat astroid v4 in the same way as v3

Fixes #164

Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added a commit to silence an error in mypy related to astroid typings; with that, all tests passed. It would make sense to add astroid 4 into the mix of what's getting tested -- I don't think it's included yet.

@dsagal dsagal merged commit 84ef059 into gristlabs:master Nov 3, 2025
18 checks passed
@fundawang
Copy link

maybe setup.cfg needs update too?

@eendebakpt
Copy link
Contributor Author

maybe setup.cfg needs update too?

I created #166

@welldone43
Copy link

Thanks for the code change, test and merge.
However, pypi.org still contains asttokens 3.0.0 from Nov 2024 as latest version.
Could you bump the latest change to pypi?

@eendebakpt
Copy link
Contributor Author

@dsagal A new release would be nice. I created #167 to add 3.14 to the CI and remove 3.8.

@welldone43
Copy link

A new release would be really great.
By now asttokens has 2..3 million downloads per day from pypi. Pytest depends on it.

@dsagal
Copy link
Member

dsagal commented Nov 15, 2025

I pushed a new release. Special thank you to @eendebakpt for the needed maintenance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asttokens uses deprecated constant from astroid

4 participants