support sqlite3_limit(id, value) via db.configure('limit', id, value) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends `db.configure` to support the `sqlite3_limit` method.
Calling `db.configure('limit', sqlite3.LIMIT_XXX, value)` is equivalent to
calling `sqlite3_limit(db, SQLITE_LIMIT_XXX, value)`.
For example, to prohibit attaching extra databases on a given database
connection, you'd call `db.configure('limit', sqlite3.LIMIT_ATTACHED, 0)`.
dsagal
approved these changes
Mar 9, 2022
| @@ -409,6 +425,15 @@ void Database::SetBusyTimeout(Baton* baton) { | |||
| delete baton; | |||
| } | |||
|
|
|||
| void Database::SetLimit(Baton* b) { | |||
| std::unique_ptr<LimitBaton> baton(static_cast<LimitBaton*>(b)); | |||
There was a problem hiding this comment.
Ah, modern C++ (i.e. from 21st century)! Looks good to me, but I don't see it used elsewhere, so wouldn't be surprised if it gets frowned upon upstream in case they are trying to support some old C++ compilers.
There was a problem hiding this comment.
Ah, this is actually me matching the latest style upstream, they've started putting this everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends
db.configureto support thesqlite3_limitmethod.Calling
db.configure('limit', sqlite3.LIMIT_XXX, value)is now equivalent to callingsqlite3_limit(db, SQLITE_LIMIT_XXX, value). For example, to prohibit attaching extra databases on a given database connection, you'd calldb.configure('limit', sqlite3.LIMIT_ATTACHED, 0). The list of possible limits is taken from https://www.sqlite.org/c3ref/c_limit_attached.htmlThis is useful for selectively reducing limits. It cannot increase limits set at compile-time.
Filed upstream at TryGhost#1548