fix memory leak in allMarshal #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the implementation of `allMarshal` to follow closely the
evolution of the implementation of `all`.
Adds a script that can be run as `npm run test:memory` to check
for obvious memory leaks.
Prior to this fix, a typical run looked like:
```
0 8081154048
1000 7443259392
2000 6777753600
3000 6128287744
4000 5500166144
5000 4849360896
6000 4221939712
7000 3558346752
8000 2960449536
9000 2309222400
10000 1655738368
11000 1019441152
```
After this fix, a typical run looks like:
```
0 8291295232
1000 8268148736
2000 8252329984
3000 8253804544
4000 8252588032
5000 8261718016
6000 8248782848
7000 8268709888
8000 8249749504
9000 8258523136
10000 8242008064
11000 8255168512
```
dsagal
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the implementation of
allMarshalto follow closely the evolution of the implementation ofall.Adds a script that can be run as
npm run test:memoryto check for obvious memory leaks.Prior to this fix, a typical run looked like (loop count, free memory):
After this fix, a typical run looks like: