Expose reading errors

DemoApps/GRDBDemoiOS/GRDBDemoWatchOS Extension/InterfaceController.swift

@@ -8,8 +8,8 @@ class InterfaceController: WKInterfaceController {
     override func awake(withContext context: Any?) {
         super.awake(withContext: context)
 
-        let persons = dbQueue.inDatabase { db in
-            Person.order(Column("name")).fetchAll(db)
+        let persons = try! dbQueue.inDatabase { db in
+            try Person.order(Column("name")).fetchAll(db)
         }
 
         table.setNumberOfRows(persons.count, withRowType: "Person")

DemoApps/GRDBDemoiOS/GRDBDemoiOS/PersonsViewController.swift

@@ -13,7 +13,7 @@ class PersonsViewController: UITableViewController {
         ]
 
         let request = personsSortedByScore
-        personsController = FetchedRecordsController(dbQueue, request: request, compareRecordsByPrimaryKey: true)
+        personsController = try! FetchedRecordsController(dbQueue, request: request, compareRecordsByPrimaryKey: true)
         personsController.trackChanges(
             recordsWillChange: { [unowned self] _ in
                 self.tableView.beginUpdates()
@@ -47,7 +47,7 @@ class PersonsViewController: UITableViewController {
             recordsDidChange: { [unowned self] _ in
                 self.tableView.endUpdates()
             })
-        personsController.performFetch()
+        try! personsController.performFetch()
 
         configureToolbar()
     }
@@ -164,19 +164,19 @@ extension PersonsViewController {
 
     @IBAction func sortByName() {
         setEditing(false, animated: true)
-        personsController.setRequest(personsSortedByName)
+        try! personsController.setRequest(personsSortedByName)
     }
 
     @IBAction func sortByScore() {
         setEditing(false, animated: true)
-        personsController.setRequest(personsSortedByScore)
+        try! personsController.setRequest(personsSortedByScore)
     }
 
     @IBAction func randomizeScores() {
         setEditing(false, animated: true)
 
         try! dbQueue.inTransaction { db in
-            for person in Person.fetch(db) {
+            for person in try Person.fetchAll(db) {
                 person.score = Person.randomScore()
                 try person.update(db)
             }
@@ -190,7 +190,7 @@ extension PersonsViewController {
         for _ in 0..<50 {
             DispatchQueue.global().async {
                 try! dbQueue.inTransaction { db in
-                    if Person.fetchCount(db) == 0 {
+                    if try Person.fetchCount(db) == 0 {
                         // Insert persons
                         for _ in 0..<8 {
                             try Person(name: Person.randomName(), score: Person.randomScore()).insert(db)
@@ -203,12 +203,12 @@ extension PersonsViewController {
                         }
                         // Delete a person
                         if arc4random_uniform(2) == 0 {
-                            if let person = Person.order(sql: "RANDOM()").fetchOne(db) {
+                            if let person = try Person.order(sql: "RANDOM()").fetchOne(db) {
                                 try person.delete(db)
                             }
                         }
                         // Update some persons
-                        for person in Person.fetchAll(db) {
+                        for person in try Person.fetchAll(db) {
                             if arc4random_uniform(2) == 0 {
                                 person.score = Person.randomScore()
                                 try person.update(db)

DemoApps/GRDBDemoiOS/GRDBDemoiOS/SimplePersonsViewController.swift

@@ -20,8 +20,8 @@ class SimplePersonsViewController: UITableViewController {
     }
 
     private func loadPersons() {
-        persons = dbQueue.inDatabase { db in
-            Person.order(Column("score").desc, Column("name")).fetchAll(db)
+        persons = try! dbQueue.inDatabase { db in
+            try Person.order(Column("score").desc, Column("name")).fetchAll(db)
         }
     }
 }

Documentation/CustomSQLiteBuilds.md

@@ -15,7 +15,7 @@ GRDB builds SQLite with [swiftlyfalling/SQLiteLib](https://github.com/swiftlyfal
 
     ```sh
     cd [GRDB.swift directory]
-    git checkout v0.90.1
+    git checkout v0.91.0
     git submodule update --init SQLiteCustom/src
     ````
 

Documentation/ExtendingGRDB.md

@@ -10,7 +10,8 @@ This guide is a step-by-step tour of GRDB extensibility, around a few topics:
     You'll learn how to turn UIColor into a value type that you can store, fetch, and use in your records:
 
     ```swift
-    for row in Row.fetch(db, "SELECT name, color FROM clothes") {
+    let rows = try Row.fetchCursor(db, "SELECT name, color FROM clothes")
+    while let row = try rows.next() {
         let name: String = row.value(named: "name")
         let color: UIColor = row.value(named: "color")      // <-- New! UIColor as value
     }
@@ -32,7 +33,8 @@ This guide is a step-by-step tour of GRDB extensibility, around a few topics:
     ```swift
     let jsonString = Column("jsonString")
     let request = Books.select(cast(jsonString, as: .blob)) // <-- New! cast function
-    for row in Row.fetch(db, request) {
+    let rows = try Row.fetchCursor(db, request)
+    while let row = try rows.next() {
         let data = row.dataNoCopy(atIndex: 0)
     }
     ```
@@ -68,9 +70,9 @@ protocol DatabaseValueConvertible {
 }
 ```
 
-The `databaseValue` property returns [DatabaseValue](../../../#databasevalue), a type that wraps the five values supported by SQLite: NULL, Int64, Double, String and Data. DatabaseValue has no public initializer: to create one, use `DatabaseValue.null`, or another type that already adopts the protocol: `1.databaseValue`, `"foo".databaseValue`, etc.
+The `databaseValue` property returns [DatabaseValue](../../../#databasevalue), a type that wraps the five values supported by SQLite: NULL, Int64, Double, String and Data. Since DatabaseValue has no public initializer, use `DatabaseValue.null`, or another type that already adopts the protocol: `1.databaseValue`, `"foo".databaseValue`, etc. Conversion to DatabaseValue *must not* fail.
 
-The `fromDatabaseValue()` factory method returns an instance of your custom type if the databaseValue contains a suitable value. If the databaseValue does not contain a suitable value, such as "foo" for Date, the method returns nil.
+The `fromDatabaseValue()` factory method returns an instance of your custom type if the databaseValue contains a suitable value. If the databaseValue does not contain a suitable value, such as "foo" for Date, `fromDatabaseValue` *must* return nil (GRDB will interpret this nil result as a conversion error, and react accordingly).
 
 **What does the DatabaseValueConvertible protocol bring to a type like UIColor?**
 
@@ -87,7 +89,8 @@ Well, you will be able to use UIColor like all other [value types](../../../#val
 - UIColor can be [extracted from rows](../../../#column-values):
 
     ```swift
-    for row in Row.fetch(db, "SELECT * FROM clothes") {
+    let rows = try Row.fetchCursor(db, "SELECT * FROM clothes")
+    while let row = try rows.next() {
         let name: String = row.value(named: "name")
         let color: UIColor = row.value(named: "color")
     }
@@ -96,7 +99,7 @@ Well, you will be able to use UIColor like all other [value types](../../../#val
 - UIColor can be [directly fetched](../../../#value-queries):
 
     ```swift
-    let colors = UIColor.fetchAll(db, "SELECT DISTINCT color FROM clothes")  // [UIColor]
+    let colors = try UIColor.fetchAll(db, "SELECT DISTINCT color FROM clothes")  // [UIColor]
     ```
 
 - Use UIColor in [Records](../../../#records):
@@ -121,7 +124,7 @@ Well, you will be able to use UIColor like all other [value types](../../../#val
 - Use UIColor in the [query interface](../../../#the-query-interface):
 
     ```swift
-    let redClothes = ClothingItem.filter(colorColumn == UIColor.red).fetchAll(db)
+    let redClothes = try ClothingItem.filter(colorColumn == UIColor.red).fetchAll(db)
     ```
 
 **Let's have UIColor adopt DatabaseValueConvertible**
@@ -468,7 +471,7 @@ Build a `value IN (...)` expression from any sequence of [values](../../../#valu
 ![1,2,3].contains(Column("id"))
 ```
 
-The most general way to generate an `IN` operator is from any value that adopts the [SQLCollection](http://cocoadocs.org/docsets/GRDB.swift/0.90.1/Protocols/SQLCollection.html) protocol, like the [query interface requests](../../../#requests):
+The most general way to generate an `IN` operator is from any value that adopts the [SQLCollection](http://cocoadocs.org/docsets/GRDB.swift/0.91.0/Protocols/SQLCollection.html) protocol, like the [query interface requests](../../../#requests):
 
 ```swift
 let request = Person.select(Column("id"))
@@ -490,7 +493,7 @@ Build a `value BETWEEN min AND max` expression from Swift ranges:
 
 #### The EXISTS Operator
 
-Build a `EXISTS(...)` expression from any value that adopts the [SQLSelectQuery](http://cocoadocs.org/docsets/GRDB.swift/0.90.1/Protocols/SQLSelectQuery.html) protocol, like the [query interface requests](../../../#requests):
+Build a `EXISTS(...)` expression from any value that adopts the [SQLSelectQuery](http://cocoadocs.org/docsets/GRDB.swift/0.91.0/Protocols/SQLSelectQuery.html) protocol, like the [query interface requests](../../../#requests):
 
 ```swift
 let request = Person.all()
@@ -502,7 +505,7 @@ request.exists()
 
 #### The COUNT Function
 
-Build a `COUNT(...)` expression from the [count](http://cocoadocs.org/docsets/GRDB.swift/0.90.1/Functions.html) and [count(distinct:)](http://cocoadocs.org/docsets/GRDB.swift/0.90.1/Functions.html) functions:
+Build a `COUNT(...)` expression from the [count](http://cocoadocs.org/docsets/GRDB.swift/0.91.0/Functions.html) and [count(distinct:)](http://cocoadocs.org/docsets/GRDB.swift/0.91.0/Functions.html) functions:
 
 ```swift
 // SQLExpression: COUNT(email)
@@ -537,7 +540,7 @@ We'll add below a Swift `cast` function:
 
 ```swift
 let request = Books.select(cast(Column("jsonString"), as: .blob))
-let jsonDatas = Data.fetchAll(db, request) // [Data]
+let jsonDatas = try Data.fetchAll(db, request) // [Data]
 ```
 
 `cast` is a top-level Swift function because this is how GRDB usually imports SQLite features which do not have matching standard Swift counterpart. It helps the Swift code looking like SQL when it is relevant. But YMMV.
@@ -593,4 +596,4 @@ You may want to compare it to another protocol, SQLSpecificExpressible, which ha
 
 > :point_up: **Note**: whenever you extend GRDB with a Swift function, method, or operator, you should generally make sure that its signature contains at least one GRDB-specific type. In the `cast` function, it is Database.ColumnType.
 
-**If SQLExpressionLiteral reveals too limited for your purpose**, you may have to implement a new type that adopts the [SQLExpression](http://cocoadocs.org/docsets/GRDB.swift/0.90.1/Protocols/SQLExpression.html) protocol.
+**If SQLExpressionLiteral reveals too limited for your purpose**, you may have to implement a new type that adopts the [SQLExpression](http://cocoadocs.org/docsets/GRDB.swift/0.91.0/Protocols/SQLExpression.html) protocol.

Documentation/FTS5Tokenizers.md

@@ -85,7 +85,7 @@ try db.execute("INSERT INTO documents VALUES (?)", arguments: ["..."])
 try Document(content: "...").insert(db)
 
 let pattern = FTS5Pattern(matchingAnyTokenIn:"...")
-let documents = Document.matching(pattern).fetchAll(db)
+let documents = try Document.matching(pattern).fetchAll(db)
 ```
 
 

Documentation/ReleaseProcess.md

@@ -7,13 +7,14 @@ To release a new GRDB version:
 
 - Tests
     - Run GRDBOX tests
-    - Run GRDBiOS tests
-    - Run GRDBCustomSQLiteOSX tests
-    - Run GRDBCustomSQLiteiOS tests
     - Run GRDBCipherOSX tests
+    - Run GRDBCustomSQLiteOSX tests
+    - Run GRDBiOS tests
     - Run GRDBCipheriOS tests
+    - Run GRDBCustomSQLiteiOS tests
     - Build and run GRDBDemoiOS
     - Build and run GRDBDemoWatchOS
+    - Check for performance regression with GRDBOSXPerformanceTests
     - `rm -rf Carthage; carthage build --no-skip-current`
     - `pod lib lint --allow-warnings`
 - On https://github.com/groue/sqlcipher.git upgrade, update SQLCipher version in README.md

GRDB.swift.podspec

@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
 	s.name     = 'GRDB.swift'
-	s.version  = '0.90.1'
+	s.version  = '0.91.0'
 
 	s.license  = { :type => 'MIT', :file => 'LICENSE' }
 	s.summary  = 'A Swift application toolkit for SQLite databases.'