Skip to content

Model Unclear text label #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2025
Merged

Model Unclear text label #318

merged 4 commits into from
Feb 22, 2025

Conversation

brandon-wada
Copy link
Collaborator

@brandon-wada brandon-wada commented Feb 21, 2025

Updating the public api spec to allow for modeling unclear text responses as null text

Copy link
Contributor

@CoreyEWood CoreyEWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the text result changes. Is a None value for text the official way to communicate "Unclear", or will that change in the future?

Also, is it fine for all the webhook changes to be in here too? Just wanted to double check.

@brandon-wada
Copy link
Collaborator Author

brandon-wada commented Feb 21, 2025

Looks good for the text result changes. Is a None value for text the official way to communicate "Unclear", or will that change in the future?

We might add another field, but even if we do that the value will remain None for unclear images.

Also, is it fine for all the webhook changes to be in here too? Just wanted to double check.

I'll be impressed if someone scoops our public-api.yaml before she merges her PR. It doesn't matter either way, but maybe for completeness I'll remove that from here

@brandon-wada brandon-wada merged commit 8755f41 into main Feb 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants