Skip to content

Update API spec #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Update API spec #353

merged 1 commit into from
Apr 28, 2025

Conversation

paulina-positronix
Copy link
Contributor

@paulina-positronix paulina-positronix commented Apr 28, 2025 •
edited
Loading

Update API spec to include optional count and multiclass mode evaluation results
Manually verified backwards compatible

brandon-wada
brandon-wada approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@brandon-wada brandon-wada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I expect this change should not affect compatibility at all - older SDK versions should ignore additional fields and new versions can accept the lack of the new fields. Sounds like you confirmed this as well

@paulina-positronix paulina-positronix merged commit 75d33fe into main Apr 28, 2025
9 checks passed
@paulina-positronix paulina-positronix deleted the update-api-count-multiclass-eval branch April 28, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-wada brandon-wada brandon-wada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulina-positronix @brandon-wada