feat: Aggregation pipeline for getting raw activity data #10498
+188
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
Nov 18, 2025
| $project: { | ||
| _id: 0, | ||
| d: '$_id', | ||
| c: '$count', |
| action: { $in: Object.values(ActivityLogActions) }, | ||
| timestamp: { | ||
| $gte: startDate, | ||
| $lt: new Date(), |
Contributor
There was a problem hiding this comment.
クエリキャッシュのパフォーマンスが低下する可能性
start date も end date も、hour, minute, second は 0 で初期化する
| date: '$timestamp', | ||
| timezone: 'Z', | ||
| }, | ||
| }, |
Contributor
There was a problem hiding this comment.
クエリキャッシュのパフォーマンスが低下する可能性
$dateTrunc を使えないか？
https://www.mongodb.com/docs/manual/reference/operator/aggregation/datetrunc/
|
|
||
| expect(aggregateMockFn).toHaveBeenCalledTimes(1); | ||
| expect(mockExec).toHaveBeenCalledTimes(1); | ||
| expect(result).toEqual(mockDbOutput); |
Contributor
There was a problem hiding this comment.
テストが「本質的なテスト」になっていない
「本質的なテスト」とは？:
- arrange, act, assert パターンに於いて、arrange で act, assert に都合のいいデータや mock を作っていないか？
- 本質的でないテストでは、act, assert に都合のいいデータや mock を作っている
- 実装を利用したテストになっているか？
- 本質的でないテストでは、実装が変わってデグレしたとしてもテストが成功してしまう
現状では、runAggregationPipeline が呼ばれたかどうかだけをテストしており、実際の buildPipeline がどのように集計しどのような集計結果になるべきかをテストしていない
arvid-e
force-pushed
the
feat/172653-contribution-graph
branch
from
c659c00 to
601f4b0
Compare
arvid-e
force-pushed
the
feat/172666-aggregation-pipeline-contribution-activity
branch
from
69e977b to
6f72cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/172653
┗ https://redmine.weseek.co.jp/issues/172666