feat(pdf-converter): Enable puppeteer-cluster config of pdf-converter from env var #10516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arafubeatbox
changed the title
arafubeatbox
commented
Nov 17, 2025
| ------------------------------------------------ | ||
|
|
||
| * [`1.0.0`, `latest` (Dockerfile)](https://github.com/growilabs/growi/blob/master/apps/pdf-converter/docker/Dockerfile) | ||
| https://github.com/growilabs/growi/blob/master/apps/pdf-converter/docker/Dockerfile |
Contributor
Author
There was a problem hiding this comment.
管理が形骸化するラベルは除去。
arafubeatbox
commented
Nov 17, 2025
| { | ||
| "name": "@growi/pdf-converter", | ||
| "version": "1.1.3-RC.0", | ||
| "version": "1.2.0", |
Contributor
Author
There was a problem hiding this comment.
リリースようにバージョン上げ。
yuki-takei
changed the title
yuki-takei
approved these changes
Nov 18, 2025
yuki-takei
deleted the
feat/174344-174345-enable-puppeteer-config-from-env-var
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
puppeteer cluster の設定を環境変数経由でできるようにする。ただし、puppeteer 本体の設定は
disable-web-securityなど危険なオプションもあるため、puppeteer-cluster の設定に留める。task
https://redmine.weseek.co.jp/issues/174345