fix: Lang setting reset on page transition #10523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Nov 19, 2025
| const [i18nPropsResult, pageDataResult] = await Promise.all([ | ||
| getServerSideI18nProps(context, ['translation']), | ||
| getPageDataForSameRoute(context), | ||
| ]); |
Member
Author
There was a problem hiding this comment.
他の NextPage と同様にページ遷移毎に毎回 getPageDataForSameRoute を getServerSideI18nProps を実行するように修正
Admin
Contributor
There was a problem hiding this comment.
getServerSideI18nProps のコストって低いのかな？
その結論付けがないまま安易に追加したくない
admin はページ遷移時のパフォーマンスを気にしないので安易に追加していいと思っている
もしコストが低いなら追加してOK、高い可能性があるなら言語変更した際はリロードを促すなどすればいいと思う
yuki-takei
requested changes
Nov 20, 2025
| const [i18nPropsResult, pageDataResult] = await Promise.all([ | ||
| getServerSideI18nProps(context, ['translation']), | ||
| getPageDataForSameRoute(context), | ||
| ]); |
Contributor
There was a problem hiding this comment.
getServerSideI18nProps のコストって低いのかな？
その結論付けがないまま安易に追加したくない
admin はページ遷移時のパフォーマンスを気にしないので安易に追加していいと思っている
もしコストが低いなら追加してOK、高い可能性があるなら言語変更した際はリロードを促すなどすればいいと思う
yuki-takei
deleted the
fix/174331-lang-setting-reset-on-page-transition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://redmine.weseek.co.jp/issues/174331