feat: Add loading spinner to admin home #10534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
requested changes
Nov 21, 2025
|
|
||
| if (adminHomeContainer.state.growiVersion == null) { | ||
| return <LoadingSpinner />; | ||
| } |
Member
There was a problem hiding this comment.
adminHomeContainer.state.growiVersion == null という条件の時に AdminHome のコンテンツが全てがローディングされるというよりかは 「システム情報」や「環境変数一覧」のテーブルだけがローディングされるという実装の方が良さそうです。
例えば 「システム情報」の場合はここらへんにローディングスピナーを書くのが良さそう。
Member
There was a problem hiding this comment.
ちなみに SystemInfomationTable.tsx というコンポーネントは AdminHome.tsx から辿れる
riona-k
changed the title
Contributor
Author
2025-11-25.12-51-33.mp4 |
miya
reviewed
Nov 25, 2025
| import { LoadingSpinner } from '@growi/ui/dist/components'; | ||
|
|
||
| type EnvVarsTableProps = { | ||
| envVars: Record<string, string | number | boolean>, |
Member
There was a problem hiding this comment.
親コンポーネントの {adminHomeContainer.state.envVars && という条件を消したなら props から渡ってくる値は nullable なはずなので以下のようにオプショナルにしておきたいです。
Suggested change
| envVars: Record<string, string | number | boolean>, | |
| envVars?: Record<string, string | number | boolean>, |
yuki-takei
changed the title
yuki-takei
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/174504
2025-11-21.16-09-32.mp4