fix: Accessing share link redirects to login page #10548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
commented
Nov 26, 2025
|
|
||
| // call superjson custom register | ||
| registerPageToShowRevisionWithMeta(); | ||
| registerShareLinkRelatedPage(); |
Member
Author
There was a problem hiding this comment.
問題2 (スコープ外)
shared page にアクセスしようとするとエラーになる
エラー
Server Error
Error: Error serializing `.page` returned from `getServerSideProps` in "/share/[[...path]]".
Reason: `object` ("[object Object]") cannot be serialized as JSON. Please only return JSON serializable data types.
This error happened while generating the page. Any console logs will be displayed in the terminal window.
Call Stack
isSerializable
webpack:/dist/esm/lib/is-serializable-props.js
every
webpack:/dist/esm/lib/is-serializable-props.js
Array.every
<anonymous>
r
webpack:/dist/esm/lib/is-serializable-props.js
isSerializableProps
webpack:/dist/esm/lib/is-serializable-props.js
e8
webpack:/dist/esm/server/render.js
async doRender
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (2315:20)
async cacheEntry.responseCache.get.routeKind
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (2569:24)
async DevServer.renderToResponseWithComponentsImpl
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (2432:24)
async DevServer.renderPageComponent
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (3016:16)
async DevServer.renderToResponseImpl
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (3078:24)
async DevServer.pipeImpl
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (1537:21)
async DevServer.NextNodeServer.handleCatchallRenderRequest
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/next-server.ts (1020:7)
async DevServer.handleRequestImpl
file:///workspace/growi/node_modules/.pnpm/[email protected]_@[email protected]_@[email protected]_@[email protected]_react-_5d5e9ca1ee36dcc657c303d88c1f04ef/node_modules/next/src/server/base-server.ts (1318:9)原因
getServerSideProps で呼んでいる シリアライザーが通常ページ用の者だったことが原因
修正方法
旧実装 (master) を参考に shared page 用のシリアライザーを新設
参考
growi/apps/app/src/pages/share/[[...path]].page.tsx
Lines 78 to 91 in c963b15
Contributor
There was a problem hiding this comment.
page-data-props.ts で返す page を通常ページにあわせて pageWithMeta にしたら専用 serializer 不要になるんじゃないかな
pageService.findPageAndMetaDataByViewer は、第4引数が isSharedPage?: boolean
Member
Author
There was a problem hiding this comment.
共通の serializer を利用するように修正しました
yuki-takei
requested changes
Nov 26, 2025
|
|
||
| // call superjson custom register | ||
| registerPageToShowRevisionWithMeta(); | ||
| registerShareLinkRelatedPage(); |
Contributor
There was a problem hiding this comment.
page-data-props.ts で返す page を通常ページにあわせて pageWithMeta にしたら専用 serializer 不要になるんじゃないかな
pageService.findPageAndMetaDataByViewer は、第4引数が isSharedPage?: boolean
miya
commented
Nov 27, 2025
| isExpired: undefined, | ||
| shareLink: undefined, | ||
| }, | ||
| }; |
| // expired | ||
| if (shareLink.isExpired()) { | ||
| const populatedPage = | ||
| await pageWithMeta.data.populateDataToShowRevision(true); //shouldExcludeBody = false, |
Member
Author
There was a problem hiding this comment.
exipired 時は revisionBody 以外を populate して返却
|
|
||
| // call superjson custom register | ||
| registerPageToShowRevisionWithMeta(); | ||
| registerShareLinkRelatedPage(); |
Member
Author
There was a problem hiding this comment.
共通の serializer を利用するように修正しました
yuki-takei
deleted the
fix/174433-accessing-share-link-redirects-to-login-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
https://redmine.weseek.co.jp/issues/174433