faet: define default user role for new user #10563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryosei-Fukushima
changed the title
miya
requested changes
Dec 4, 2025
|
|
||
| // Customize Settings | ||
| 'customize:isEmailPublishedForNewUser', | ||
| 'customize:isReadOnlyForNewUser', |
Member
There was a problem hiding this comment.
この Prefix (customize:) は Admin 画面のどのページで管理するかという指定方法になっている。この場合は「カスタマイズ設定」になる。
初期 user を readOnly で作成する設定は「カスタマイズ設定」よりかは「アプリ設定」の方が良さそう。
UI でいうとここら辺かな。
Contributor
Author
There was a problem hiding this comment.
ありがとうございます。修正しました。
apps/app/src/server/models/user.js
Outdated
| } | ||
|
|
||
| newUser.readOnly = | ||
| configManager.getConfig('customize:isReadOnlyForNewUser') ?? false; |
Member
There was a problem hiding this comment.
configManager.getConfig('customize:isReadOnlyForNewUser') は null を許容していない (true or false が返却される) と思うので ?? false は不要そう
yuki-takei
merged commit 87fa352
into
feat/174791-default-user-role-setting-api
14 checks passed
yuki-takei
deleted the
feat/174791-175195-define-default-user-role-for-new-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redmine
https://redmine.weseek.co.jp/issues/175195
設定値の作成
config-definition.ts で新しい設定キーを追加し、デフォルト値を変更することで、新規ユーザーをデフォルトで readOnly にできることを確認しました。