fix: ensure tag list updates immediately after editing #10577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miya
requested changes
Dec 8, 2025
| await apiPost('/tags.update', updateTagsData); | ||
| if (pageId != null) { | ||
| await mutate(key => JSON.stringify(key).includes(pageId), undefined, { revalidate: true }); | ||
| } |
Member
There was a problem hiding this comment.
- これだと何が mutate されているか分かりにくいです
- String.prototype.includes() だと意図しないキーがマッチして無駄な再検証が走る可能性があります (本来やりたいことは tag の再検証のみ)
- useSWRxTagsInfo から提供される mutate を使って実装してみてほしいです
- updateStateAfterSave の中に mutate に実装しても良さそうです
riona-k
force-pushed
the
fix/tag-edit-modal-update
branch
from
52b6953 to
8405d83
Compare
miya
reviewed
Dec 10, 2025
| await apiPost('/tags.update', updateTagsData); | ||
| if (mutateTags != null) { | ||
| await mutateTags(); | ||
| } |
Member
There was a problem hiding this comment.
mutateTags って nullable じゃなさそうなので null check は不要そう
Member
There was a problem hiding this comment.
あと、これは非同期でも良さそうなので await もいらないかも (更新が成功したら即時トースターをだしたいので)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/174438
2025-12-08.14-51-29.mp4