Add EventSource and activity tags to server - #341
Merged
Merged
Conversation
JamesNK
force-pushed
the
jamesnk/eventsource
branch
2 times, most recently
from
June 21, 2019 07:46
d4604f4 to
be0f551
Compare
lmolkova
reviewed
Jun 21, 2019
lmolkova
reviewed
Jun 21, 2019
lmolkova
reviewed
Jun 21, 2019
JamesNK
changed the title
davidfowl
reviewed
Jun 22, 2019
davidfowl
reviewed
Jun 22, 2019
JunTaoLuo
approved these changes
Jun 23, 2019
JunTaoLuo
left a comment
JunTaoLuo
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I would prefer a new gRPC activity but we can address that separately if you want to get this merged.
JamesNK
force-pushed
the
jamesnk/eventsource
branch
2 times, most recently
from
June 28, 2019 08:51
8d43821 to
984fde5
Compare
Member
Author
|
@lmolkova @davidfowl All feedback applied. |
lmolkova
reviewed
Jun 28, 2019
lmolkova
reviewed
Jun 28, 2019
lmolkova
reviewed
Jun 28, 2019
JamesNK
force-pushed
the
jamesnk/eventsource
branch
from
July 15, 2019 06:48
63d31cf to
ffe1119
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #318, #283
Built on top of #334Changes in c986480