Revert "stats/opentelemetry: record retry attempts from clientStream (#8342)" (#8571)

This introduced flakiness in a test -
Test/TraceSpan_WithRetriesAndNameResolutionDelay
Failure:
https://github.com/grpc/grpc-go/actions/runs/17614152882/job/50042942932?pr=8547

Related issue: #8299

RELEASE NOTES: None

Author: eshitachandwani

stats/opentelemetry/client_tracing.go

@@ -21,7 +21,6 @@ import (
 	"log"
 	"strings"
 
-	"go.opentelemetry.io/otel/attribute"
 	otelcodes "go.opentelemetry.io/otel/codes"
 	"go.opentelemetry.io/otel/trace"
 	"google.golang.org/grpc"
@@ -84,10 +83,7 @@ func (h *clientTracingHandler) finishTrace(err error, ts trace.Span) {
 // It creates a new outgoing carrier which serializes information about this
 // span into gRPC Metadata, if TextMapPropagator is provided in the trace
 // options. if TextMapPropagator is not provided, it returns the context as is.
-//
-// Note: The passed attemptInfo pointer (ai) is mutated in-place. Fields such as
-// ai.traceSpan are updated directly. No new attemptInfo is returned.
-func (h *clientTracingHandler) traceTagRPC(ctx context.Context, ai *attemptInfo, nameResolutionDelayed bool) context.Context {
+func (h *clientTracingHandler) traceTagRPC(ctx context.Context, ai *attemptInfo, nameResolutionDelayed bool) (context.Context, *attemptInfo) {
 	// Add a "Delayed name resolution complete" event to the call span
 	// if there was name resolution delay. In case of multiple retry attempts,
 	// ensure that event is added only once.
@@ -102,7 +98,7 @@ func (h *clientTracingHandler) traceTagRPC(ctx context.Context, ai *attemptInfo,
 	carrier := otelinternaltracing.NewOutgoingCarrier(ctx)
 	h.options.TraceOptions.TextMapPropagator.Inject(ctx, carrier)
 	ai.traceSpan = span
-	return carrier.Context()
+	return carrier.Context(), ai
 }
 
 // createCallTraceSpan creates a call span to put in the provided context using
@@ -125,12 +121,7 @@ func (h *clientTracingHandler) HandleConn(context.Context, stats.ConnStats) {}
 // TagRPC implements per RPC attempt context management for traces.
 func (h *clientTracingHandler) TagRPC(ctx context.Context, info *stats.RPCTagInfo) context.Context {
 	ctx, ai := getOrCreateRPCAttemptInfo(ctx)
-	ci := getCallInfo(ctx)
-	if ci == nil {
-		logger.Error("context passed into client side stats handler (TagRPC) has no call info")
-		return ctx
-	}
-	ctx = h.traceTagRPC(ctx, ai, info.NameResolutionDelay)
+	ctx, ai = h.traceTagRPC(ctx, ai, info.NameResolutionDelay)
 	return setRPCInfo(ctx, &rpcInfo{ai: ai})
 }
 
@@ -141,15 +132,5 @@ func (h *clientTracingHandler) HandleRPC(ctx context.Context, rs stats.RPCStats)
 		logger.Error("ctx passed into client side tracing handler trace event handling has no client attempt data present")
 		return
 	}
-
-	// Client-specific Begin attributes.
-	if begin, ok := rs.(*stats.Begin); ok {
-		ci := getCallInfo(ctx)
-		previousRPCAttempts := ci.previousRPCAttempts.Add(1) - 1
-		ri.ai.traceSpan.SetAttributes(
-			attribute.Int64("previous-rpc-attempts", int64(previousRPCAttempts)),
-			attribute.Bool("transparent-retry", begin.IsTransparentRetryAttempt),
-		)
-	}
 	populateSpan(rs, ri.ai)
 }