stats/opentelemetry: record retry attempts from clientStream

[vinothkumarr227]

Fixes: #8299

RELEASE NOTES:

• stats/opentelemetry: Retry attempts (grpc.previous-rpc-attempts) are now recorded as span attributes for non-transparent client retries.

[codecov]

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.48%. Comparing base (85240a5) to head (9b13b21).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
stats/opentelemetry/client_tracing.go	55.55%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8342      +/-   ##
==========================================
- Coverage   82.48%   82.48%   -0.01%     
==========================================
  Files         413      413              
  Lines       40518    40546      +28     
==========================================
+ Hits        33422    33445      +23     
- Misses       5738     5743       +5     
  Partials     1358     1358              

Files with missing lines	Coverage Δ
stats/opentelemetry/client_metrics.go	85.16% <100.00%> (+0.08%)	⬆️
stats/opentelemetry/opentelemetry.go	77.90% <ø> (ø)
stats/opentelemetry/trace.go	90.47% <100.00%> (+1.58%)	⬆️
stats/opentelemetry/client_tracing.go	82.85% <55.55%> (-4.65%)	⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[purnesh42H]

I remember we had separate tests for retries. This change should only affect that test. This change shouldn't affect tests which are doing only single attempt.

[purnesh42H]

@vinothkumarr227 have you tested this to ensure its working correctly? I was under impression that TestTraceSpan_WithRetriesAndNameResolutionDelay will need changes for expected values. I think its not working as expected because you are not setting the count back to ctx after incrementing.

[arjan-bal]

LGTM, adding a second reviewer. Please address the minor comment.

[arjan-bal]

Please add the (s) back.

[vinothkumarr227]

Done

[arjan-bal]

@vinothkumarr227 there is a failure in the updated test reported by codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342

PTAL and ensure the test is not flaky.

[vinothkumarr227]

@vinothkumarr227 there is a failure in the updated test reported by codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342

PTAL and ensure the test is not flaky.

Sure, I’ll check it out.

[vinothkumarr227]

@vinothkumarr227 there is a failure in the updated test reported by codecov: https://github.com/grpc/grpc-go/actions/runs/16616024027/job/47008766111?pr=8342

PTAL and ensure the test is not flaky.
Hi @arjan-bal , I tested the test locally and everything passed consistently. I’ve now merged the latest changes from master, and all test cases are passing.

[dfawley]

Why is this a TODO?

Isn't this simply?

attribs := []attribute.KeyValue{...Bool("Client", rs.Client), /* etc */}
if ai.previousRPCAttempts != nil {
	attribs = append(attribs, attribute.Int64("prev...", ..), ...)
}

[vinothkumarr227]

Thanks for the suggestion. Per @arjan-bal recommendation, this will be handled in a separate PR, which is why it's a TODO. I've created an issue for reference: #8430

[dfawley]

I'm not sure I understand why. If these attributes are not supposed to be present, then wouldn't it be incorrect to include them.

[vinothkumarr227]

Thanks Doug. I've made changes and pushed the fix.

[dfawley]

Oh it was already setting these things?

Also what is this about "Go was always setting these attributes even though they aren't in the spec"?

Are we intentionally not implementing the spec? Why are we mentioning the OC spec in the OT plugin? I'm kind of lost here, TBH.