transport: move to internal to make room for new, public transport API #2212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
added
the
Type: API Change
menghanl
reviewed
Jul 10, 2018
internal/transport/transport.go
Outdated
| @@ -19,7 +19,7 @@ | |||
| // Package transport defines and implements message oriented communication | |||
| // channel to complete various transactions (e.g., an RPC). It is meant for | |||
| // grpc-internal usage and is not intended to be imported directly by users. | |||
| package transport // externally used as import "google.golang.org/grpc/transport" | |||
| package transport // externally used as import "google.golang.org/grpc/internal/transport" | |||
There was a problem hiding this comment.
Should we just delete the comment on this line?
dfawley
force-pushed
the
internal_transport
branch
from
74cf340 to
bb5d02b
Compare
menghanl
approved these changes
Jul 11, 2018
|
I forget the name of the laws of APIs, but it goes something like this: something like: if err == transport.ErrConnClosing {
log.Printf("[ERROR err=%q", err)
break SomeJump // The transport is closing, afaik this is not a bug
}w e'll pin to 1.13 . AFAIK that should have been a major version increment though. (2.0.0) |
|
agree with @MaerF0x0 this is major version increment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but the transport package was never intended for use outside of grpc. Any current users that we are aware of are incorrect or have a preferred alternative.