Skip to content

Cherry-pick #8159 and #8243 to v1.72.x #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Apr 16, 2025

Original PRs: #8159 #8243

RELEASE NOTES:

  • ringhash: implement gRFC A76

@purnesh42H purnesh42H added the Type: Feature New features or improvements in behavior label Apr 16, 2025
@purnesh42H purnesh42H added this to the 1.72 Release milestone Apr 16, 2025
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 97.46835% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (79ca174) to head (fe4b92f).
Report is 1 commits behind head on v1.72.x.

Files with missing lines Patch % Lines
internal/testutils/xds/e2e/clientresources.go 75.00% 1 Missing and 1 partial ⚠️
xds/internal/balancer/ringhash/picker.go 96.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           v1.72.x    #8255      +/-   ##
===========================================
+ Coverage    82.07%   82.17%   +0.09%     
===========================================
  Files          410      412       +2     
  Lines        40236    40346     +110     
===========================================
+ Hits         33024    33153     +129     
+ Misses        5856     5842      -14     
+ Partials      1356     1351       -5     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
internal/metadata/metadata.go 82.08% <100.00%> (+1.44%) ⬆️
internal/testutils/envconfig.go 100.00% <100.00%> (ø)
resolver/ringhash/attr.go 100.00% <100.00%> (ø)
...internal/balancer/clusterresolver/configbuilder.go 91.22% <100.00%> (+0.05%) ⬆️
xds/internal/balancer/ringhash/config.go 92.30% <100.00%> (+3.41%) ⬆️
xds/internal/balancer/ringhash/ring.go 100.00% <100.00%> (+7.14%) ⬆️
xds/internal/balancer/ringhash/ringhash.go 94.22% <100.00%> (+0.35%) ⬆️
xds/internal/balancer/ringhash/util.go 100.00% <100.00%> (ø)
xds/internal/resolver/serviceconfig.go 85.71% <100.00%> (ø)
... and 3 more

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also cherrypick #8243 in the same PR?

Also mention the target branch name in the PR description.

@purnesh42H purnesh42H changed the title Cherry-pick 8159 Cherry-pick #8159 and #8243 to v1.72.x Apr 16, 2025
@purnesh42H
Copy link
Contributor Author

Can you also cherrypick #8243 in the same PR?

Also mention the target branch name in the PR description.

Done. I thought there will be conflict

@purnesh42H purnesh42H requested a review from arjan-bal April 16, 2025 09:29
@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Apr 16, 2025
@purnesh42H purnesh42H merged commit fd6f585 into grpc:v1.72.x Apr 16, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants