xdsclient: add an e2e style test for fallback involving more than 2 servers #7817 #8427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8427 +/- ##
==========================================
+ Coverage 82.27% 82.29% +0.02%
==========================================
Files 414 414
Lines 40424 40436 +12
==========================================
+ Hits 33259 33277 +18
- Misses 5795 5798 +3
+ Partials 1370 1361 -9 🚀 New features to boost your workflow:
|
|
|
||
| // Secondary2 fallback, RPCs reach backend3. | ||
| secondary2Lis.Restart() | ||
| if err := waitForRPCsToReachBackend(ctx, client, backend3.Address); err != nil { |
There was a problem hiding this comment.
Test to verify if connections are attempted to primary and secondary1 backends.
| if conn, err := secondary2WrappedLis.NewConnCh.Receive(ctx); err == nil { | ||
| cw := conn.(*testutils.ConnWrapper) | ||
| if _, err := cw.CloseCh.Receive(ctx); err != nil { | ||
| t.Fatalf("Failed to get connection to secondary2: %v", err) |
There was a problem hiding this comment.
The error message is wrong. Here we are checking if connection to secondary2 is closed or not because we not have secondary1 running. Change the error message.
| })) | ||
| if conn, err := secondary1WrappedLis.NewConnCh.Receive(ctx); err == nil { | ||
| cw := conn.(*testutils.ConnWrapper) | ||
| cw.CloseCh.Receive(ctx) |
There was a problem hiding this comment.
Is there a reason we do not have a similar check here?
There was a problem hiding this comment.
Thanks for pointing that out! I’ve updated the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7817
RELEASE NOTES: