Skip to content

stub: Have disableAutoRequest() on server-side #7071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2020

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented May 27, 2020

This splits server-side flow control from client-side, but tailors the API for
each case. Client-side continues having disableAutoRequestWithInitial(). While
client-side could have disableAutoRequest(), it seems like it will only rarely
be used and disableAutoRequestWithInitial(0) isn't that bad. So we leave it off
for now; we can always add it in the future.


When this is merged I will sync it internally by itself, so that I can fix up the one
user of the current API (being replaced).

This API change was discussed at #1788 (comment)

This is intended to be backported into 1.30.

This splits server-side flow control from client-side, but tailors the API for
each case. Client-side continues having disableAutoRequestWithInitial(). While
client-side could have disableAutoRequest(), it seems like it will only rarely
be used and disableAutoRequestWithInitial(0) isn't that bad. So we leave it off
for now; we can always add it in the future.
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label May 27, 2020
@ejona86 ejona86 requested a review from voidzcy May 27, 2020 23:08
@voidzcy
Copy link
Contributor

voidzcy commented May 27, 2020

The usage in manual flow control example needs to be changed (see CI failure). Other than that, the changes LGTM.

@ejona86
Copy link
Member Author

ejona86 commented May 28, 2020

@voidzcy, PTAL. My change to the example wasn't quite trivial.

@ejona86
Copy link
Member Author

ejona86 commented May 29, 2020

@voidzcy, PTAL

Copy link
Contributor

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we go 😃

@ejona86 ejona86 merged commit 0201c5a into grpc:master May 29, 2020
@ejona86 ejona86 deleted the disable-auto-request branch May 29, 2020 22:05
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label May 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants