stub: Have disableAutoRequest() on server-side #7071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits server-side flow control from client-side, but tailors the API for each case. Client-side continues having disableAutoRequestWithInitial(). While client-side could have disableAutoRequest(), it seems like it will only rarely be used and disableAutoRequestWithInitial(0) isn't that bad. So we leave it off for now; we can always add it in the future.
ejona86
added
the
TODO:backport
|
The usage in manual flow control example needs to be changed (see CI failure). Other than that, the changes LGTM. |
|
@voidzcy, PTAL. My change to the example wasn't quite trivial. |
voidzcy
reviewed
May 28, 2020
examples/src/main/java/io/grpc/examples/manualflowcontrol/ManualFlowControlServer.java
Outdated
Show resolved
Hide resolved
|
@voidzcy, PTAL |
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits server-side flow control from client-side, but tailors the API for
each case. Client-side continues having disableAutoRequestWithInitial(). While
client-side could have disableAutoRequest(), it seems like it will only rarely
be used and disableAutoRequestWithInitial(0) isn't that bad. So we leave it off
for now; we can always add it in the future.
When this is merged I will sync it internally by itself, so that I can fix up the one
user of the current API (being replaced).
This API change was discussed at #1788 (comment)
This is intended to be backported into 1.30.