stub: stabilize StreamObserver APIs #7938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Mar 4, 2021
| @@ -50,7 +48,6 @@ | |||
| * <p>DO NOT MOCK: The API is too complex to reliably mock. Use InProcessChannelBuilder to create | |||
| * "real" RPCs suitable for testing. | |||
| */ | |||
| @ExperimentalApi("https://github.com/grpc/grpc-java/issues/1788") | |||
| public abstract class CallStreamObserver<V> implements StreamObserver<V> { | |||
There was a problem hiding this comment.
I thought this class was to remain experimental.
There was a problem hiding this comment.
If this class remains experimental, then its subclasses should also be experimental. We can not have a stable class extend an experimental class.
There was a problem hiding this comment.
We talked of redefining the methods in the subclasses, so the only issue is if someone references CallStreamObserver directly.
There was a problem hiding this comment.
Reverted CallStreamObserver.java.
There was a problem hiding this comment.
I was referencing #1788 (comment) before.
There was a problem hiding this comment.
Redefined methods of CallStreamObserver in subclasses.
ejona86
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving #1788