Skip to content

Add request/response type to method definition #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kurayama
Copy link

Adds the resolved request/response type to grpc-loader method definition.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@nicolasnoble nicolasnoble requested a review from murgatroid99 May 28, 2018 21:31
@nicolasnoble
Copy link
Member

@kurayama thank you for your contribution, but in order for us to accept it, we'd need you to follow the instructions provided by the CLA bot ☝️. Thanks!

@kurayama
Copy link
Author

@nicolasnoble done

@murgatroid99
Copy link
Member

Thank you for your contribution, but we cannot accept it. One of the design goals of this library was to avoid directly exposing the API of Protobuf.js, and this change would break that. I understand the value of exposing this information, and I would be open to suggestions about other ways to do it.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants