Skip to content

Add RequestType and ResponseType metadata to method definition #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add RequestType and ResponseType metadata to method definition #408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fd0d20
Add RequestType and ResponseType metadata to method definition
Jmoore1127 Jun 21, 2018
bd60cfa
Fix requestType and responseType typings
Jmoore1127 Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/grpc-protobufjs/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ export interface MethodDefinition<RequestType, ResponseType> {
requestDeserialize: Deserialize<RequestType>;
responseDeserialize: Deserialize<ResponseType>;
originalName?: string;
requestType: Protobuf.Type;
responseType: Protobuf.Type;
}

export interface ServiceDefinition {
Expand Down Expand Up @@ -97,7 +99,9 @@ function createMethodDefinition(method: Protobuf.Method, serviceName: string, op
responseSerialize: createSerializer(method.resolvedResponseType as Protobuf.Type),
responseDeserialize: createDeserializer(method.resolvedResponseType as Protobuf.Type, options),
// TODO(murgatroid99): Find a better way to handle this
originalName: _.camelCase(method.name)
originalName: _.camelCase(method.name),
requestType: method.resolvedRequestType as Protobuf.Type,
responseType: method.resolvedResponseType as Protobuf.Type,
};
}

Expand Down