Skip to content

L43: Node Message Type Information #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2018
Merged

L43: Node Message Type Information #116

merged 2 commits into from
Dec 12, 2018

Conversation

murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Nov 19, 2018 •
edited
Loading

This was referenced Nov 19, 2018
Closed
Closed
wenbozhu
wenbozhu approved these changes Nov 27, 2018
View reviewed changes
Copy link
Member

@wenbozhu wenbozhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good approach, i.e. using proto3 JSON to represent the (well-defined) descriptor data.

@murgatroid99 murgatroid99 merged commit 5c612a6 into grpc:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenbozhu wenbozhu wenbozhu approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murgatroid99 @wenbozhu