forked from alanjds/grumpy
-
Notifications
You must be signed in to change notification settings - Fork 18
Implement the 'reverse' option for sorted() #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
imported PR
Pull Request imported from google/grumpy
waiting feedback
Waiting confirmation of changes or fixes
Comments
That all sounds good. Let me know when I should review again. |
This was referenced Oct 6, 2018
Merged
While #102 is merged, it is not proper implementation, even without implementation of key or cmp:
It will certainly affect types which implements comparison methods. |
:/ |
sorted([1,1.0,2,2.0], reverse=True)
. Comparison or Stability?
sorted([1,1.0,2,2.0], reverse=True)
. Comparison or Stability?sorted([1,1.0,2,2.0], reverse=True)
results
sorted([1,1.0,2,2.0], reverse=True)
results
Closing in favor of #120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
imported PR
Pull Request imported from google/grumpy
waiting feedback
Waiting confirmation of changes or fixes
google#162 opened on Jan 18, 2017 by @MirkoDziadzka
Add the 'reverse' option to 'sorted()'
I'm not sure if this violates the 'stable sort definition in Python.
On the other hand, this is probably only relevant when key or cmp gets implemented.
The text was updated successfully, but these errors were encountered: