Skip to content

Support ci/default-values.yaml #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Support ci/default-values.yaml #133

merged 2 commits into from
Jun 9, 2025

Conversation

james03160927
Copy link
Contributor

Description

Fixes #130

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

@james03160927 james03160927 self-assigned this Jun 3, 2025
@james03160927 james03160927 requested a review from arsci as a code owner June 3, 2025 21:52
ZachGoldberg
ZachGoldberg previously approved these changes Jun 4, 2025
@james03160927
Copy link
Contributor Author

Hi @ZachGoldberg, addressed one of the comment. Can I get another approval for this? Thanks.

@james03160927 james03160927 merged commit e93068a into master Jun 9, 2025
3 checks passed
@james03160927 james03160927 deleted the add-ci-values branch June 9, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helmlint: support ci/default-values.yaml in addition to linter_values.yaml
3 participants