Improvements to newfile dialog, open links, other fixes#2277

Merged

gsantner merged 12 commits into

gsantner:masterfrom

harshad1:improvements_to_newfile_dialog

May 19, 2024

Collaborator

harshad1 commented May 5, 2024 •

edited

Loading

In this PR I have added the ability to format at new file title similarly to how we format snippets.

Additionally, we now remember template and name format per file type.

This should

address Add ability to set a default note title to enable quicker new note creation #2225 (default note title is yyyyMMddHHmmSS)
address Add the ability to choose a default note Type and Template #2217
minimize FileManager: New file, file type not consistent with suffix #2199
Also includes an unrelated fix for Bug report: "Recently viewed documents" not updated after I view some documents #2153

EDIT:
I have merged in my open links in tags PR so more things have been pulled in here:

Open any link in an html tag (such as our audio attachment format)
Fixes for new files not showing when newfile dialog rotated
Tweaks to prevent screen flashing when file opened in view mode

harshad1 added 5 commits

April 20, 2024 20:18


          Added logic to open any 'src' in a tag

1f19f0d


          Preserver dialog callback on rotation

4f40150


          before simplifying

5ced6cc


          simplified

1d62db7


          Now with a seaparate format edit

c0ea432

Collaborator Author

harshad1 commented May 5, 2024

harshad1 commented

View reviewed changes

app/src/main/assets/templates/cooking-recipe.md

harshad1 commented

View reviewed changes

app/src/main/assets/templates/hugo-post-front-matter.md


          Cleanup imports

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentShareIntoFragment.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/format/FormatRegistry.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/frontend/MarkorDialogFactory.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/frontend/NewFileDialog.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserListAdapter.java Outdated

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserOptions.java Outdated


          merged and tweaked

3bce89b

harshad1 mentioned this pull request

Open resources in a tag #2275

Closed

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/activity/MainActivity.java

harshad1 changed the title ~~Improvements to newfile dialog~~ Improvements to newfile dialog, open links, other fixes

This was linked to issues May 12, 2024

Add ability to set a default note title to enable quicker new note creation #2225

Closed

Add the ability to choose a default note Type and Template #2217

Closed

FileManager: New file, file type not consistent with suffix #2199

Closed

Bug report: "Recently viewed documents" not updated after I view some documents #2153

Closed

Markdown: Support for definition lists #2215

Open

gsantner removed a link to an issue

Markdown: Support for definition lists #2215

Open

4 tasks

gsantner assigned harshad1

gsantner added bug enhancement labels

gsantner reviewed

View reviewed changes

app/src/main/java/net/gsantner/markor/format/FormatRegistry.java

+                  public static class Format {
+                      public final @StringRes int format, name;
+                      public final String ext;

Owner

gsantner May 12, 2024 •

edited

Loading

Suggestion please make ext / it's handling as regex instead

Collaborator Author

harshad1 May 12, 2024

These are just meant to be a source of truth, not used for matching etc. i.e. this says ' The canonical extension for markdown is ".md" '

Format and FORMATS is not meant to match or detect formats - that is left to the isFileOutOfThisFormat as before.

gsantner reviewed

View reviewed changes

app/src/main/java/net/gsantner/markor/format/FormatRegistry.java

gsantner reviewed

View reviewed changes

app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserFragment.java Outdated

gsantner and others added 4 commits

May 12, 2024 06:05


          Merge branch 'master' into improvements_to_newfile_dialog

51e39c9


          Merge branch 'master' into improvements_to_newfile_dialog

e0e8f79


          Moving from separate callbacks to a single refresh call

d8f93fd


          Update favourites properly

3fdd6b2

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/format/todotxt/TodoTxtAutoTextFormatter.java

                   @Override
                   public CharSequence filter(CharSequence source, int start, int end, Spanned dest, int dstart, int dend) {
                       try {
-                          if (start < source.length() && dstart <= dest.length() && TextViewUtils.isNewLine(source, start, end)) {

Collaborator Author

harshad1 May 13, 2024

Moved some functions from TextViewUtils to GsTextUtils

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/opoc/frontend/filebrowser/GsFileBrowserOptions.java

                       public Collection<File> favouriteFiles, recentFiles, popularFiles = null;
                       public GsCallback.a1<CharSequence> setTitle = null, setSubtitle = null;
+                      public GsCallback.a0 refresh = null;

Collaborator Author

harshad1 May 13, 2024

Reverted back to just having collections and added a refresh callback here. The refresh callback is called in loadFolder() and can be used to do whatever.

harshad1 commented

View reviewed changes

app/src/main/java/net/gsantner/markor/frontend/filebrowser/MarkorFileBrowserFactory.java

+                          opts.recentFiles = appSettings.getRecentFiles();
+                          opts.popularFiles = appSettings.getPopularFiles();
+                      };
+                      opts.refresh.callback();

Collaborator Author

harshad1 May 13, 2024

Setting the refresh callback to update sorting, fav file lists etc etc.


          Fix to stop views flashing incorrectly when navigating fast

73a868f

gsantner added this to the Markor v2.13 milestone

gsantner merged commit f35383a into gsantner:master

gsantner added a commit that referenced this pull request


          Reformat code of PR #2277, closes #2225, closes #2217, closes #2199, c…

23b726e

…loses #2153

gsantner added a commit that referenced this pull request


          Fix crash for unknown filetypes, fix EmbedBinary not detected, relate…

a210dcc

…d to PR #2277

gsantner mentioned this pull request

Bug Report: Delayed Appearance of Newly Created Folders #2250

Closed

4 tasks

Owner

gsantner commented May 21, 2024

Broke a few things -> #2297

harshad1 deleted the improvements_to_newfile_dialog branch

August 18, 2024 19:16

Owner

gsantner commented May 23, 2025 •

edited

Loading

Hello @harshad1 , I found commit f35383a which duplicated the samples folder as well.

Now we have the samples here and here.

Which one is or should be the right one, do you know why did we not just keep the original one and have a copy statement to assets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment