Skip to content

Quick filter all files, Share files into markor#2521

Merged
gsantner merged 77 commits into
gsantner:masterfrom
harshad1:quick_filter_all_files
Apr 14, 2025
Merged

Quick filter all files, Share files into markor#2521
gsantner merged 77 commits into
gsantner:masterfrom
harshad1:quick_filter_all_files

Conversation

@harshad1
Copy link
Copy Markdown
Collaborator

@harshad1 harshad1 commented Feb 6, 2025

This PR adds 2 new features:

  1. a quick filter - search for all files in the notebook by tapping on the title.
  2. Share files into markor to attach them to documents. From download folder for example. Files will be copied into notebook like the usual file attachment system

Also included are a ton of fixes and improvements:

  • File browser sorting and loading (especially special folders)
  • Improved delete dialog
  • Speed improvements (2-3x) for the search (on my device at least)
  • undo / redo will track file load

Comment thread app/src/main/res/layout/document__fragment__edit.xml
@harshad1 harshad1 changed the title WIP: Quick filter all files Quick filter all files, Share files into markor Mar 31, 2025
@harshad1
Copy link
Copy Markdown
Collaborator Author

@gsantner This is ready.

Please let me know if you would like me to break this into smaller PRs

Copy link
Copy Markdown
Owner

@gsantner gsantner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsantner gsantner merged commit b2f4407 into gsantner:master Apr 14, 2025
1 check passed
@cinnabar777
Copy link
Copy Markdown

I just installed the latest marder and opening files from a file explorer is now broken. Now gives notice about sync app, but I'm not using such a thing, and this combination of markor and MiXplorer haven't ever had such a problem.

As best as I can find it's due to this PR.

gsantner added a commit that referenced this pull request Oct 23, 2025
…th stopped working for most cases, closes #2653, by @gsantner

Was changed in b2f4407 - PR #2521
lrq3000 added a commit to lrq3000/markor that referenced this pull request Mar 14, 2026
Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR gsantner#2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
Using OpenCode with ChatGPT Codex-5.3 + git-bisect
lrq3000 added a commit to lrq3000/markor that referenced this pull request Mar 14, 2026
Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR gsantner#2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
Using OpenCode with ChatGPT Codex-5.3 + git-bisect
lrq3000 added a commit to lrq3000/markor that referenced this pull request Mar 14, 2026
Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR gsantner#2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
Using OpenCode with ChatGPT Codex-5.3 + git-bisect
gsantner pushed a commit that referenced this pull request Mar 19, 2026
…wn (#2769)

* fix: stabilize editor layout sizing to prevent large-file open slowdown

Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR #2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

* docs: add lrq3000 in CONTRIBUTORS.md
* fix: Refactor speed regression fix duplications into a function syncEditorMinHeightOnce() to do one-shot editor min-height sync to prevent large-file open slowdown + cover more cases as originally intended in 64ff85b

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
gsantner added a commit that referenced this pull request Mar 19, 2026
…wn (PR #2769, closes #2739 #2652 #2716)

* fix: stabilize editor layout sizing to prevent large-file open slowdown

Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR #2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

* docs: add lrq3000 in CONTRIBUTORS.md
* fix: Refactor speed regression fix duplications into a function syncEditorMinHeightOnce() to do one-shot editor min-height sync to prevent large-file open slowdown + cover more cases as originally intended in 64ff85b

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
gsantner added a commit that referenced this pull request Mar 19, 2026
…wn (PR #2769, closes #2739 #2652 #2716)

* fix: stabilize editor layout sizing to prevent large-file open slowdown

Restore one-shot min-height initialization and avoid per-layout min-height churn, with guardrail comments to prevent reintroducing startup relayout regressions.

This fixes a major speed regression introduced in commit 64ff85b in PR #2521 (squashed into b2f4407) that made loading of big files and opening the keyboard incredibly slow and proportional to the file size.

* docs: add lrq3000 in CONTRIBUTORS.md
* fix: Refactor speed regression fix duplications into a function syncEditorMinHeightOnce() to do one-shot editor min-height sync to prevent large-file open slowdown + cover more cases as originally intended in 64ff85b

Signed-off-by: Stephen L. <LRQ3000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[View Mode]: Back button doesn't return to editor

3 participants