Skip to content

Rebuild SubmenuButton when onOpen is called #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LongCatIsLooong
Copy link

        child = MergeSemantics(
          child: Semantics(
            expanded: controller.isOpen,
            child: ...
          ),
       ),

didn't work because it depends on controller.isOpen but the widget doesn't automatically rebuild when isOpen changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gspencergoog gspencergoog force-pushed the menu_overlay_portal branch 2 times, most recently from b0356f5 to da587e7 Compare October 16, 2023 20:30
@LongCatIsLooong LongCatIsLooong deleted the rebuild-submenu-button-on-open branch October 17, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant