cairo: write-to-stream callbacks should accept const pointers to data #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
previously approved these changes
Aug 5, 2025
sdroege
added
the
needs-backport
|
Added a fix for the clippy warnings here |
|
Shouldn't the clippy warning fix be done in a separate PR? It's not even cairo code. |
|
As more fixes are needed now, yes. |
|
I'll rebase this here later once it's otherwise passing. |
This is in line with the [corresponding C types](https://www.cairographics.org/manual/cairo-PNG-Support.html#cairo-write-func-t); they don't need to mutate this data. Closes gtk-rs#1771.
sdroege
force-pushed
the
write-func-const-data
branch
from
802e07b to
5b83717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the corresponding C types; they don't need to mutate this data.
Closes #1771.