glib-macros: Add thread_local_object macro #775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Erhardt <[email protected]>
AaronErhardt
force-pushed
the
master
branch
from
f87460e to
46ca67b
Compare
sdroege
reviewed
Sep 30, 2022
| ::std::thread_local!(static THREAD_LOCAL_OBJ: #ty = #init_stream); | ||
|
|
||
| pub fn #name() -> #ty { | ||
| THREAD_LOCAL_OBJ.with(|w| w.clone()) |
Member
There was a problem hiding this comment.
Why not use something from once_cell here? Then you wouldn't have to export a function but could export a value that derefs to the object
Contributor
Author
There was a problem hiding this comment.
Wow, that actually works 😅. Because unsync::Lazy::new is const you can use it in global const variables. I wasn't aware that you could use non-Send values in global constants, but that seems to work pretty well actually. I guess this makes this PR rather obsolete then...
sdroege
reviewed
Sep 30, 2022
| } | ||
| } | ||
|
|
||
| impl ToTokens for ThreadLocalObjectTokens { |
Member
There was a problem hiding this comment.
This could also just be a declarative macro in the glib crate or not? :) Having it as a proc-macro just complicates things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it is useful to have access to an object (or widget) as a static variable. Unfortunately, the thread_local API of the standard library is pretty inconvenient and requires a couple of lines of boilerplate to setup a convenient wrapper function.
This new macro simplifies this process. Of course it's really not the most important thing to have, but I wanted to submit a PR here first instead of making this only available in Relm4.