Skip to content

book: Second libadwaita section #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Sep 28, 2022
Merged

book: Second libadwaita section #1112

merged 19 commits into from
Sep 28, 2022

Conversation

Hofer-Julian
Copy link
Collaborator

No description provided.

@Hofer-Julian Hofer-Julian force-pushed the Hofer-Julian/book-todo-4 branch from d6cb1fa to e10dd82 Compare September 14, 2022 08:43
@Hofer-Julian Hofer-Julian marked this pull request as ready for review September 19, 2022 20:03
Copy link
Collaborator Author

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

</interface>
```

In order to create the pageholder page as displayed before, we combine a flat header bar with [`adw::StatusPage`](https://world.pages.gitlab.gnome.org/Rust/libadwaita-rs/stable/latest/docs/libadwaita/struct.StatusPage.html).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure. In the gnome HIG the head bar is indeed not flat.

@Exalm since I've copied that from you. How do you feel about that?

@Hofer-Julian Hofer-Julian merged commit 70676d8 into master Sep 28, 2022
@Hofer-Julian Hofer-Julian deleted the Hofer-Julian/book-todo-4 branch September 28, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants