fix: 'Incorrect token audience' error for GitHubOidcProvider
#1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
changed the title
GitHubOidcProvider
rtyley
changed the title
GitHubOidcProviderGitHubOidcProvider
rtyley
force-pushed
the
fix-incorrect-token-audience-error-when-using-configure-aws-credentials-github-action
branch
from
10db93b to
cef0bfa
Compare
This is an update to the construct that creates IAM resources for GitHub Actions, first introduced with #823 in early October 2021. Apparently the `ClientIdList` field should no longer be `sigstore`, as of 19th October 2021: aws-actions/configure-aws-credentials#291 aws-actions/configure-aws-credentials#280 (comment) aws-actions/configure-aws-credentials#284 The new value is `sts.amazonaws.com`, which I think corresponds to this line in the docs: > For the "Audience": Use sts.amazonaws.com if you are using the official action. https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services#adding-the-identity-provider-to-aws With the old value of `sigstore` in the `AWS::IAM::OIDCProvider` `ClientIdList` field, running the `aws-actions/configure-aws-credentials` GitHub Action will give you a "Error: Incorrect token audience" error: https://github.com/guardian/facia-scala-client/runs/7025740057?check_suite_focus=true#step:3:6
rtyley
force-pushed
the
fix-incorrect-token-audience-error-when-using-configure-aws-credentials-github-action
branch
from
cef0bfa to
36a4bdf
Compare
|
The Dependabot is the typical solution here, but it wasn't quite working. I've dropped the requirement to have this check pass, as we should think of ways to automate this. |
akash1810
approved these changes
Jun 23, 2022
rtyley
deleted the
fix-incorrect-token-audience-error-when-using-configure-aws-credentials-github-action
branch
|
🎉 This PR is included in version 45.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to the
GitHubOidcProviderconstruct that creates IAM resources for GitHub Actions, first introduced by PR #823 in early October 2021 - apparently theClientIdListvalue should no longer besigstore, as of 19th October 2021!The new value is
sts.amazonaws.com, which I think corresponds to this line in the GitHub docs:When using the old value of
sigstorein theAWS::IAM::OIDCProviderClientIdListfield, running theaws-actions/configure-aws-credentialsGitHub Action will give you an"Error: Incorrect token audience"error:https://github.com/guardian/facia-scala-client/runs/7025740057?check_suite_focus=true#step:3:6