Skip to content

use types for breakpoints #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2018
Merged

use types for breakpoints #21

merged 4 commits into from
Feb 9, 2018

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Feb 9, 2018

cahnges the breakpoint exports from functions that take a string to finite objects, so that flow will complain if you try to use an invalid breakpoint

before

from('tablet')
until('mobileLandscape')
between('mobileLandscape', 'tablet')

now

from.tablet (or just tablet)
until.mobileLandscape
between.mobileLandscape.and.tablet

has handy side affect of providing us with autocomplete if you have it:
image

@sndrs sndrs requested review from GHaberis and SiAdcock February 9, 2018 13:37
@sndrs sndrs merged commit 498d364 into master Feb 9, 2018
@sndrs sndrs deleted the named-breakpoint branch February 9, 2018 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant