Add telemetry to 'free only' and 'uploaded by me' filters#3996
Merged
Conversation
andrew-nowak
approved these changes
Dec 19, 2022
prout-bot
added
Pending-on-auth
Pending-on-collections
Pending-on-cropper
Pending-on-image-loader
Pending-on-kahuna
Pending-on-leases
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-thrall
Pending-on-usage
Seen-on-collections
Seen-on-cropper
Seen-on-kahuna
Seen-on-media-api
Seen-on-metadata-editor
and removed
Pending-on-cropper
Pending-on-media-api
Pending-on-metadata-editor
Pending-on-collections
Pending-on-kahuna
labels
|
Seen on metadata-editor, cropper, collections, media-api, kahuna (merged by @rhystmills 11 minutes and 2 seconds ago) Please check your changes! |
|
Seen on usage (merged by @rhystmills 11 minutes and 12 seconds ago) Please check your changes! |
|
Seen on thrall (merged by @rhystmills 11 minutes and 17 seconds ago) Please check your changes! |
prout-bot
added
Seen-on-auth
Seen-on-image-loader
Seen-on-leases
and removed
Pending-on-leases
Pending-on-image-loader
Pending-on-auth
labels
|
Seen on auth, image-loader, leases (merged by @rhystmills 11 minutes and 20 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds telemetry to the 'Free only' and 'Uploaded by me' checkboxes.
How should a reviewer test this change?
Run the grid locally. Change the checkboxes. Does a network request go out (shortly afterwards) to the telemetry
eventendpoint with a suitably payload?Tested? Documented?