Skip to content

"gethexaformat" messes up column widths #86

Closed
@cpacejo

Description

@cpacejo

This patch and this patch seem to have messed up column widths. E.g. the Unicode character "𝔹" (U+1D539) is counted as double-width. Before these patches, it did not fall in any of the double-width ranges. However, after these patches, gethexaformat conflates U+1D539 with U+D539 (픹), which is considered as a wide character.

I don't understand what the purpose of gethexaformat is -- it seems to just be performing the bitwise operation x & 0xFFFF, but using text parsing? Why are only the least significant 16 bits considered when determining whether a character is wide? This seems like it would cause many characters beside my example to have the wrong width...

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions