feat!: Switch stream implementation to streamx#333
Merged
phated merged 61 commits intogulpjs:masterfrom Jun 11, 2023
Merged
Conversation
phated
requested changes
Apr 23, 2023
Member
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Thanks for updating this. I've made some comments, but they are mostly for me to remember what needs to be done to finish up this PR
phated
force-pushed
the
chore-normalize-repository
branch
from
1872d25 to
b88a77e
Compare
phated
reviewed
Jun 10, 2023
phated
changed the title
This was
linked to
issues
Jun 11, 2023
Closed
Closed
phated
approved these changes
Jun 11, 2023
Member
phated
left a comment
phated
left a comment
There was a problem hiding this comment.
Tests should be green now and I'm happy enough with the diff. Thanks for getting this started @coreyfarrell and thanks for updating @sttk 🎉 This truly was a team effort.
Merged
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR inherits #322 and updates this repository more for the following points:
Upgrades dependencies and drops node <10.13 support
rimraf's version is 3, not latest, because the latest version 4 supports only node>=14.eslint,expect, andmochaupgrades to the last versions which supports node v10.Drops
through2and makes use ofstreamxDrops
mississippiandreadable-streamDrops
remove-bom-buffer, butis-utf8is used.Skips 2 test cases about directory symlink on Node.js v10 and Windows
Because
EPERMerror occurs only on this environment.In addition, I tryed to drop
pumpifyby usingstreamx, etc. in.dest()and.symlink()but cloudn't do them.NOTE: This package depends on
glob-streamwhich will be bumped up.