Open
Conversation
Owner
|
This is a PowerShell script for Windows, does it even run on MacOS? |
Author
|
Yes :D powershell is cross platform so you can install it with Homebrew on Mac. Bash is usually better for most things but since you already had a powershell script, I figured it would be easier to adapt that. The only cross platform weirdness is that Mac can't handle backslashes as path separators. I believe Windows supports both forward and backward slashes, hence the change in my pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds app bundles for MacOS to the published artifacts so that you can now drag and drop the LogicAnalyzer program into your applications like a proper MacOS application.
I had hoped to make minimal changes to the publish script, but I needed to:
bashdirectly instead of throughwsl. The logic ended up being large so I extracted this into its own functionI had decided to name the zip files
app-LogicAnalyzer_6.0.0-osx-x64.app.zipandapp-LogicAnalyzer_6.0.0-osx-arm64.app.zip. When you unzip them, you'll see the app show up.If I have more time I might try to make the icon look a little prettier. Maybe some gradients and shadows will help.
Unfortunately, this doesn't solve the signing/notarization problem.