Add support ssh:// URL and github local branch name fix. #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hum it's missing the third commit 😖 |
"third commit" means local branch name fix? I will keep it to #144. (I think it has a little relation to GitBucket support). |
|
merged 👍 |
guyzmo
reviewed
Apr 30, 2017
| elif url.startswith('git@'): | ||
| if url.endswith('.git'): | ||
| url = url[:-4] | ||
| elif url.find('@') > -1 and url.find(':') > -1: |
There was a problem hiding this comment.
so you know, this is not very pythonic, the pythonic way is if '@' in url 😉
There was a problem hiding this comment.
Oh, thanks for comments!
guyzmo
added a commit
that referenced
this pull request
May 8, 2017
First anniversary release 🎂 This release marks the first anniversary and 10th release of git-repo 🎉 Now git-repo supports 6 git services: github, gitlab, bitbucket, gogs, gitea and gitbucket It supports the following commands: clone, fork, create, delete, add, open, ls, request, gist And it's becoming relatively stable (keep sending bug reports 🙏) ♥ Contributors Thanks to @kounoike for the gitbucket support 🙌 Now there are three contributors promoted to collaborators: * @kounoike, @pyhedgehog and @Crazybus 🚧 Features * When add has no parameters, add default remote #100 #141 * When add has 'upstream' parameter, add the upstream remote #99 #141 * Use default branch instead of hardcoded 'master' #91 * Refactor and complete bitbucket support #43 #11 #80 #14 #89 #90 #79 * Loosen versions of dependencies #133 * Report if the service is already setup #136 * Adds GitBucket support #142 #144 * Adds support for ssh:// URL #148 🚒 Bugfixes * fix various crashes #152 * fix gitlab clone crash #129 * fix request create command #147 #127 * fix request fetch command #138 #131 * fix wizard crash #149 * fix mishandling of renamed gitlab project urls #137 📝 Documentation * documentation #145 Signed-off-by: Guyzmo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by Git manual git command also supports ssh:// style URL. It is useful for GitBucket supoprt(#144).
And Gogs/Gitea can use any user for ssh access. This change accepts any user on scp-style
user@server:pathto/repo.git.