Merged
Conversation
Signed-off-by: Frank Hossfeld <frank.hossfeld@googlemail.com>
jnehlmeier
approved these changes
Oct 30, 2024
|
@FrankHossfeld I would squash the 5 commits into 1 before merging into master...low prio though |
Member
Author
Not sure how to do that with the browser. But the one who merges it can say squash and merge. |
Member
|
Yes, we default to squash commit merges (and the title/description become the commit message), in keeping with the basic idea from gerrit, to keep history clear and linear, and keep the author’s focus on the content for any given PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link to the GWT Gitter/Matrix room is broken. This will fix it.