support asserting JSON types other than objects (fixes #16) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvic
force-pushed
the
json-generic-assertion
branch
from
2c0e5ea to
a914fad
Compare
|
Can't believe i'm running into this golang/go#14493 |
The JSON matching is is adjusted to compared marshalled values instead of bytes because the order of JSON object keys is non deterministic and therefore can cause comparisons to fail.
dvic
force-pushed
the
json-generic-assertion
branch
from
a914fad to
3591283
Compare
|
Fixed the issue with go 1.7 by taking a pointer to |
|
Thank you! Will bump the major version since this introduce breaking changes. |
|
New version is out! Thanks for the PR. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON matching is is adjusted to compared marshalled values instead of bytes because the order of JSON object keys is non deterministic and therefore can cause comparisons to fail.