fix: 🐛 explicitly cast step report in wandb logs to int

llm_studio/python_configs/cfg_checks.py

@@ -23,10 +23,14 @@ def check_config_for_errors(cfg: DefaultConfigProblemBase) -> dict:
     - "message": A list of error messages.
     """
     errors = check_for_common_errors(cfg)
+    logging_errors = check_for_logging_errors(cfg)
     problem_type_errors = cfg.check()
     errors["title"].extend(problem_type_errors["title"])
     errors["message"].extend(problem_type_errors["message"])
     errors["type"].extend(problem_type_errors["type"])
+    errors["title"].extend(logging_errors["title"])
+    errors["message"].extend(logging_errors["message"])
+    errors["type"].extend(logging_errors["type"])
     return errors
 
 
@@ -108,3 +112,17 @@ def check_for_common_errors(cfg: DefaultConfigProblemBase) -> dict:
         ]
         errors["type"].append("error")
     return errors
+
+
+def check_for_logging_errors(cfg: DefaultConfigProblemBase) -> dict:
+    errors: dict[str, list] = {"title": [], "message": [], "type": []}
+
+    if cfg.logging.logger == "W&B" and cfg.logging.log_step_size == "relative":
+        errors["title"] += ["WandB relative step size logging not supported."]
+        errors["message"] += [
+            "WandB logging does not support relative step size logging. "
+            "Please set log_step_size to 'absolute' when using WandB logging."
+        ]
+        errors["type"].append("error")
+
+    return errors

llm_studio/src/loggers.py

@@ -92,6 +92,10 @@ def __init__(self, cfg: Any) -> None:
 
     def log(self, subset: str, name: str, value: Any, step: int | None = None):
         name = f"{subset}/{name}"
+        if step is not None:
+            # NOTE: Explicit cast is needed, as training sometimes reports float steps
+            step = int(step)
+
         self.logger.log({name: value}, step=step)
 
 

tests/python_configs/test_cfg_checks.py

@@ -14,6 +14,7 @@ def __init__(self):
         self.environment = MagicMock()
         self.architecture = MagicMock()
         self.training = MagicMock()
+        self.logging = MagicMock()
 
     def check(self):
         return {"title": [], "message": [], "type": []}