Skip to content

Conversation

@sulhicader
Copy link
Contributor

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

Closes #2453

@sulhicader sulhicader added security Related to security dependencies Pull requests that update a dependency file labels Apr 5, 2025
@sulhicader sulhicader self-assigned this Apr 5, 2025
@sulhicader sulhicader requested review from lo5 and mturoci as code owners April 5, 2025 11:33
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sulhicader. Please also go through all the examples that use these and make sure they still work. Include demo videos in this PR.

bokeh==2.4.2
Faker==13.3.4
h2o-wave-ml==0.8.1
h2o-wave[ml]==1.6.3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this version coming from? The last wave-ml version is 0.8.1 if I see correctly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this change to get the newer version of h2o3 (installed as its dependency). But it seems like newest version is installed even with h2o-wave-ml==0.8.1. So Don't need this change.

@sulhicader
Copy link
Contributor Author

Thanks @sulhicader. Please also go through all the examples that use these and make sure they still work. Include demo videos in this PR.

Examples which uses changed dependencies work fine.

Deployed app instance - https://cloud-dev.h2o.dev/instance/c74b454a-f4bb-4b5c-906b-822a42df1ca7/

Demo Video -:

Screen.Recording.2025-04-08.at.14.32.06.mov

@sulhicader sulhicader mentioned this pull request Apr 8, 2025
5 tasks
@mturoci
Copy link
Collaborator

mturoci commented Apr 8, 2025

Demo Video -:

None of the examples in the video use the changed dependencies.

Deployed app instance - https://cloud-dev.h2o.dev/instance/c74b454a-f4bb-4b5c-906b-822a42df1ca7/

image

@sulhicader
Copy link
Contributor Author

Here I added a new demo which compare the examples with the 1.5.1 version in internal dedicated

Link to Demo -: https://drive.google.com/file/d/1cgq9OI3aA1a-hLJ9FwJu4RySpwUVzoV2/view?usp=drive_link

Instance already has the All user visibility. If still face the problem You may try to start your own instance from here

@mturoci mturoci merged commit d7008c4 into main Apr 9, 2025
5 checks passed
@mturoci mturoci deleted the fix/vuln_wave_tour branch April 9, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file security Related to security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update versions of Relevant Python dependencies in Wave Tour app to remove the High and Critical vulnerabilities in runtime image

2 participants