fix: allow returning, number and boolean as well#65
Merged
Conversation
Member
|
It would be better if we check already resolved type against JSON-safe values rather than assuming all values as response |
pi0
reviewed
Mar 11, 2022
| if (type === 'string') { | ||
| return send(res, val, MIMES.html) | ||
| } else if (type === 'object' && val !== undefined) { | ||
| } else if (['bigint', 'number', 'boolean', 'object'].includes(type)) { |
Member
There was a problem hiding this comment.
For maximum performance, we could avoid iteration and add 4 == checks.
pi0
changed the title
pi0
changed the title
Member
|
Removed bigint. JSON.parse seems unable to handle bigint by default (https://stackoverflow.com/questions/18755125/node-js-is-there-any-proper-way-to-parse-json-with-large-numbers-long-bigin) |
danielroe
commented
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #48
This enables us to send a response for:
We may wrongly return a response for functions & symbols. Though likely that's a user error rather than something h3 should check for.