Skip to content

fix: allow returning, number and boolean as well #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pi0 merged 6 commits into from
Mar 11, 2022
Merged

fix: allow returning, number and boolean as well #65

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f7569f3
fix: return non-object values as well
danielroe Mar 10, 2022
78756ed
refactor: explicitly list types we will return
danielroe Mar 11, 2022
6871c1c
perf: avoid iteration
danielroe Mar 11, 2022
0b03a94
Update app.ts
pi0 Mar 11, 2022
517e476
Update src/app.ts
danielroe Mar 11, 2022
c9fb15e
update formatting
pi0 Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export function createHandle (stack: Stack, options: AppOptions): PHandle {
const type = typeof val
if (type === 'string') {
return send(res, val, MIMES.html)
} else if (type === 'object' && val !== undefined) {
} else if (['bigint', 'number', 'boolean', 'object'].includes(type)) {
Copy link
Copy Markdown
Member

@pi0 pi0 Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For maximum performance, we could avoid iteration and add 4 == checks.

// Return 'false' and 'null' values as JSON strings
if (val && val.buffer) {
return send(res, val)
Expand Down