docs: updated visualization for dispatch request lifecycle#1115
Merged
docs: updated visualization for dispatch request lifecycle#1115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Member
|
Two suggestions from the current diagram:
If it helps, this is actual code. |
Contributor
Author
|
couldn't make mermaid display flowchart well, here are some attempts made, which graph suit the documentation most? |
Member
|
Updated with simplified seq diagram. How do you think? %%{init: {'theme':'neutral'}}%%
sequenceDiagram
participant MiddlewareA as Middleware1(event, next)
participant MiddlewareB as Middleware2(event, next)
participant Route as RouteHandler(event)
MiddlewareA-->MiddlewareA: onRequest(event)
MiddlewareA->>+MiddlewareB: await next()
MiddlewareB-->MiddlewareB: onRequest(event)
MiddlewareB->>+Route: await next()
Route->>Route: RouteHandler(event)
Route-->>-MiddlewareB: rawBody
MiddlewareB-->>-MiddlewareA: rawBody
MiddlewareA-->MiddlewareA: sendResponse(event, rawBody)
|
Contributor
Author
|
This looks simpler and easier to understand than the one I suggested! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated visualization for dispatch request lifecycle to be clearer.
MiddlewareAhas to be in vertical, or else it's too long to to see the details.