Merged
Conversation
Deploying h3dev with
|
| Latest commit: |
7aaac00
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cbdfeb3.h3dev.pages.dev |
| Branch Preview URL: | https://feat-h3-core.h3dev.pages.dev |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes
H3Core, an abstract class without implementation for_findRouteto allow replacing the router.Bundle size saving is medium (
7.4kBcore vs9.6kBwith rou3), but the main benefit is giving better low-level control.With this PR, we also expose
_routes: []internal array useful for next steps, both accessing nested app route meta (#1111) and better sub-app (#1107) since we can "replay" route additions tothe main app when mounting it.